Mass Engine Update #1220
Open
Mass Engine Update #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update submodule to 228.0.0 * Fix every single test * Also this one
github-actions
bot
added
Changes: C#
This comment was marked as resolved.
This comment was marked as resolved.
|
I have run into a problem I do not know how to fix. Woe. |
That why engine update for EE is pain and @VMSolidus take a lot of time for updates. |
|
OH LORD... ENGINES UPDATES.... ITS AGONY. |
* partial buckling refactor * git mv test * change test namespace * git mv test * Update test namespace * Add pulling test * Network BuckleTime * Add two more tests * smelly
This reverts commit 1741356.
* Replaced uses of Dirty(Component) with Dirty(Uid, Component) Modified some systems (notably pulling-related) to use uids. * Missed a few * Revert changes to pulling * No
|
By request, I have implemented space-wizards/space-station-14#26238 |
* Fix storage UI interactions * Add VV support
|
Now includes space-wizards/space-station-14#28541 |
i actually needed this, godspeed funny birb man |
I'm actively making it work, you should likely wait until it does. |
* Extra checks to prevent ghosts spawning on terminating maps/grids * Add test for grid deletion
* Add failing unbuckle InteractHand test * Skip trybuckle if strap doesn't have space * Unbuckle others not just user * Fix test failing due to delay * Change to raise event instead of calling OnInteractHand * Add test for buckle and unbuckle on InteractHand * Add tick delay * Remove unneeded tick delay and clean up * Comment code * Cleanup * Swap to fastest checks first * Fix reading empty sequence when there are no buckled entities
* Add failing unbuckle InteractHand test * Skip trybuckle if strap doesn't have space * Unbuckle others not just user * Fix test failing due to delay * Change to raise event instead of calling OnInteractHand * Add test for buckle and unbuckle on InteractHand * Add tick delay * Remove unneeded tick delay and clean up * Comment code * Cleanup * Swap to fastest checks first * Fix reading empty sequence when there are no buckled entities
* Add failing unbuckle InteractHand test * Skip trybuckle if strap doesn't have space * Unbuckle others not just user * Fix test failing due to delay * Change to raise event instead of calling OnInteractHand * Add test for buckle and unbuckle on InteractHand * Add tick delay * Remove unneeded tick delay and clean up * Comment code * Cleanup * Swap to fastest checks first * Fix reading empty sequence when there are no buckled entities
* Buckling an entity requires a do-after * Works but feels like bad code? * Cleanup --------- Co-authored-by: plykiya <[email protected]>
* Replace IAlertClick with events * whoop * eek!
This reverts commit fe67113.
This reverts commit be8a62e.
This reverts commit 3b0d51d.
This reverts commit df5dbf2.
This reverts commit 3323706.
…98)" This reverts commit 85ce424.
This reverts commit 5a8b36a.
This reverts commit 5e682c0.
This reverts commit bd43299.
This reverts commit fe67113.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to do all engine updates in one go. Not focusing on content associated, only what's needed for it to run and any bug fixes.